Subject: Re: [PATCH] Add uboot commandline argument passing support to
 m68knommu (Try #2)
From: Daniel Walker <dwalker@fifo99.com>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
       uclinux-dev@uclinux.org
In-Reply-To: <20090918174936.GJ23702@csclub.uwaterloo.ca>
References: <20090918162736.GY23700@csclub.uwaterloo.ca>
	 <1253291944.7060.42.camel@desktop>
	 <20090918174936.GJ23702@csclub.uwaterloo.ca>
Content-Type: text/plain
Date: Fri, 18 Sep 2009 10:54:01 -0700
Message-Id: <1253296441.7060.49.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 904
Lines: 20

On Fri, 2009-09-18 at 13:49 -0400, Lennart Sorensen wrote:
> On Fri, Sep 18, 2009 at 09:39:04AM -0700, Daniel Walker wrote:
> > You have a couple of various checkpatch errors in this patch. We use
> > scripts/checkpatch.pl to check for code style issues. Could you run that
> > on your patch and fix any errors it finds? A couple are whitespace
> > related and you can use scripts/cleanpatch or scripts/cleanfile to
> > remove whitespace (so I hear. I've never run those scripts personally)
> 
> Oh dear.  I guess the original patch was a bit messy then.  OK here we
> go again with a checkpatch approved patch.

Much better, thanks for doing that..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/