Subject: Re: [PATCH] nfs: fix bdi_unregister() before sb kill
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, a.p.zijlstra@chello.nl
In-Reply-To: <20090918200530.GL23126@kernel.dk>
References: <20090917194027.GS23126@kernel.dk>
	 <1253229410.2783.16.camel@heimdal.trondhjem.org>
	 <20090918064006.GU23126@kernel.dk> <20090918150248.GB23126@kernel.dk>
	 <1253290790.3183.14.camel@heimdal.trondhjem.org>
	 <20090918173608.GD23126@kernel.dk> <20090918183203.GG23126@kernel.dk>
	 <1253299218.3183.84.camel@heimdal.trondhjem.org>
	 <20090918184602.GJ23126@kernel.dk> <20090918200157.GK23126@kernel.dk>
	 <20090918200530.GL23126@kernel.dk>
Content-Type: text/plain
Date: Fri, 18 Sep 2009 16:11:58 -0400
Message-Id: <1253304721.3183.97.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1616
Lines: 42

On Fri, 2009-09-18 at 22:05 +0200, Jens Axboe wrote:
> On Fri, Sep 18 2009, Jens Axboe wrote:
> > On Fri, Sep 18 2009, Jens Axboe wrote:
> > > On Fri, Sep 18 2009, Trond Myklebust wrote:
> > > > On Fri, 2009-09-18 at 20:32 +0200, Jens Axboe wrote:
> > > > > How does this look? It compiles, but I cannot test before sunday. It
> > > > > would be great if you (or someone else) could :-). Peter, if you have
> > > > > the time, it would be nice if you could check whether this one works for
> > > > > you too.
> > > > > 
> > > > > diffstat is tasty, too:
> > > > > 
> > > > >  client.c |    4 ----
> > > > >  super.c  |   53 ++++++++++++++++++++++++++---------------------------
> > > > >  2 files changed, 26 insertions(+), 31 deletions(-)
> > > > 
> > > > Yep! The patch looks good to me. I'll see if I can find the time to test
> > > > it tomorrow.
> > > 
> > > Thanks a lot! I'll try nfs over wifi on the laptop now, since the test
> > > boxes are off.
> > 
> > Took a little longer than it should have, since latest -git breaks my
> > iwl3945. Anyway, it works fine for me. The patch is tentatively
> > committed as:
> > 
> > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=0841ff4261ae91b01c923be97843753c56a6613a
> 
> Trond, OK if I commit this? It works here, and it definitely doesn't
> make things worse :-)
> 

That would be fine by me.

Cheers
  Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/