Subject: Re: [patch] x86, apic: use logical flat on intel with <= 8 logical
 cpus
From: Daniel Walker <dwalker@fifo99.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu, yinghai@kernel.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <1253325936.3948.720.camel@sbs-t61.sc.intel.com>
References: <1253325936.3948.720.camel@sbs-t61.sc.intel.com>
Content-Type: text/plain
Date: Fri, 18 Sep 2009 19:19:50 -0700
Message-Id: <1253326790.6699.38.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1041
Lines: 23

On Fri, 2009-09-18 at 19:05 -0700, Suresh Siddha wrote:
> +               switch (boot_cpu_data.x86_vendor) {
> +                       case X86_VENDOR_INTEL:
> +                               if (num_processors > 8)
> +                                       apic = &apic_physflat;
> +                               break;
> +                       case X86_VENDOR_AMD:
> +                               if (max_physical_apicid >= 8)
> +                                       apic = &apic_physflat;
> +               }

There are a couple of checkpatch issues in this patch .. Could you run
it through and fix the errors that show up.. One is that you need 1 less
tab for the code inside the switch statement .. You have another switch
statement in apic.c that needs similar attention .

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/