Date: Sat, 19 Sep 2009 10:35:55 +0200
From: Sam Ravnborg <sam@ravnborg.org>
To: Tim Abbott <tabbott@ksplice.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>, linux-m32r@ml.linux-m32r.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] Linker script cleanup patches for m32r
Message-ID: <20090919083555.GA25840@merkur.ravnborg.org>
References: <1253305969-6948-1-git-send-email-tabbott@ksplice.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1253305969-6948-1-git-send-email-tabbott@ksplice.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1462
Lines: 39

On Fri, Sep 18, 2009 at 04:32:43PM -0400, Tim Abbott wrote:
> This is an updated version of the patch series I sent on September 6
> cleaning up the m32r architecture's linker scripts.  It differs from V1
> in that I moved spi_stack_top and spu_stack_top to .init.data at
> Hirokazu Takata's request.
> 
> This cross-architecture linker script cleanup project is in
> preparation for adding support for building the kernel with
> -ffunction-sections -fdata-sections, which is a prerequisite for
> Ksplice.
> 
> 	-Tim Abbott
> 
> Tim Abbott (6):
>   m32r: make PAGE_SIZE available to assembly.
>   m32r: Define THREAD_SIZE only once.
>   m32r: Move GET_THREAD_INFO definition out of asm/thread_info.h.
>   m32r: Remove unused .altinstructions and .exit.* code from linker
>     script.
>   m32r: Move the spi_stack_top and spu_stack_top into .init.data
>     section.
>   m32r: Cleanup linker script using new linker script macros.

Looked through all of these - looks good.
I like how you take the time to do the additional cleanups
that is possible.
Next step would be to introduce the 'normal' style in the linker
script but that can come later.

Acked-by: Sam Ravnborg <sam@ravnborg.org>

For all 6 patches.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/