From: Oliver Neukum <oliver@neukum.org>
To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH] kaweth: Fix memory leak in kaweth_control()
Date: Sat, 19 Sep 2009 21:19:37 +0200
User-Agent: KMail/1.10.3 (Linux/2.6.31-rc9-0.1-default; KDE/4.1.3; x86_64; ; )
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       linux-usb@vger.kernel.org
References: <6a1f935a6229adafb68d0e1ca7bc71fa@localhost>
In-Reply-To: <6a1f935a6229adafb68d0e1ca7bc71fa@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200909192119.37988.oliver@neukum.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 903
Lines: 24

Am Samstag, 19. September 2009 03:43:30 schrieb Kevin Cernekee:
> kaweth_control() never frees the buffer that it allocates for the USB
> control message.  Test case:
>
> while :; do ifconfig eth2 down ; ifconfig eth2 up ; done
>
> This is a tiny buffer so it is a slow leak.  If you want to speed up the
> process, you can change the allocation size to e.g. 16384 bytes, and it
> will consume several megabytes within a few minutes.

You are right, the patch is correct. But it has to go to netdev, as it
is for a network driver. Please resend it and add
Acked-by: Oliver Neukum <oliver@neukum.org>

Greg, it should go into stable, too.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/