Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbZITPDx (ORCPT ); Sun, 20 Sep 2009 11:03:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752237AbZITPDw (ORCPT ); Sun, 20 Sep 2009 11:03:52 -0400 Received: from mail-px0-f196.google.com ([209.85.216.196]:33811 "EHLO mail-px0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbZITPDv (ORCPT ); Sun, 20 Sep 2009 11:03:51 -0400 Message-ID: <4AB6441D.5070805@vflare.org> Date: Sun, 20 Sep 2009 20:32:53 +0530 From: Nitin Gupta Reply-To: ngupta@vflare.org User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Pekka Enberg CC: Hugh Dickins , Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp Subject: Re: [PATCH 2/4] send callback when swap slot is freed References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253227412-24342-3-git-send-email-ngupta@vflare.org> <1253256805.4959.8.camel@penberg-laptop> <1253260528.4959.13.camel@penberg-laptop> <1253266391.4959.15.camel@penberg-laptop> <4AB3A16B.90009@vflare.org> <4AB487FD.5060207@cs.helsinki.fi> In-Reply-To: <4AB487FD.5060207@cs.helsinki.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 33 Hi Pekka, On 09/19/2009 12:57 PM, Pekka Enberg wrote: > > Nitin Gupta wrote: >> It is understood that this swap notify callback is bit of a hack. I think >> we will not gain much trying to beautify this hack. However, I agree with >> Hugh's suggestion to rename this notify callback related >> function/variables >> to make it explicit that its completely ramzswap related. I will send >> a path that affects these renames as reply to patch 0/4. > > I don't quite agree and do think that my approach is a better long-term > solution. That said, it's Hugh's call, not mine. Hugh? > Ok, lets discard all this. I will soon start working on a generic notifier based interface for various swap events: swapon, swapoff, swap slot free that I hope would be more acceptable. I will now surely miss this merge window but I hope the end result would be better. The issue of swap_lock is still bugging me but I think atomic notifier list should be acceptable for swap slot free event, at least for the initial revision. If this particular event finds more users then we will have to work on reducing contention on swap_lock (per-swap file lock?). Thanks, Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/