Date: Sun, 20 Sep 2009 13:12:29 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
To: Greg KH <greg@kroah.com>
cc: Tilman Schmidt <tilman@imap.cc>, <linux-usb@vger.kernel.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: Status of Bug 8094 -  ipaq oops on connecting "Vodafone VPA-II"
 ?
In-Reply-To: <20090920150549.GC11621@kroah.com>
Message-ID: <Pine.LNX.4.44L0.0909201308550.8307-100000@netrider.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1407
Lines: 33

On Sun, 20 Sep 2009, Greg KH wrote:

> On Sun, Sep 20, 2009 at 03:39:57PM +0200, Tilman Schmidt wrote:
> > When I connect my "T-Mobile MDA compact III" to my PC, running
> > kernel 2.6.31 with openSUSE 10.3 userspace, I get exactly the
> > symptoms described in:
> > 
> > http://bugzilla.kernel.org/show_bug.cgi?id=8094
> > 
> > But that bug is marked as "CLOSED CODE_FIX", though reading through
> > the comments I found no clear indication what was actually fixed,
> > and from reading through the source files drivers/usb/serial/ipaq.c
> > and drivers/usb/serial/usb-serial.c I get the impression that the
> > problem of ipaq_open() oopsing because it gets called with
> > port->read_urb==NULL is still present.

Interestingly, the fix from that bug report _was_ merged as commit
063a2da8f01806906f7d7b1a1424b9afddebc443 (written by me).  But then it
was removed later on(!) in commits
07c3b1a1001614442c665570942a3107a722c314 and
9aebfd6bda789891e6d296bb49b5fb32d1057f18 (written by Greg).

Apparently the check should have been moved from the core into the 
lower-level driver (i.e., ipaq.c) but it wasn't.  I don't know why; 
maybe Greg does.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/