DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=Y1rZNDcuWCcqLVvNQsrJILtTTM9EnYzs9VV3yQ4/KCYKng/oic9KELDFlankL09fd4
         4wNshDj19VML0gi0v0JYAnUZA015fQmJd0KP4Uvglzu0OCjtgKZOKCvv9ewCIgOf5LJ/
         kGJVcL9gaJ0r2Wmcav3kIIQbk6mh9eexV9rd0=
MIME-Version: 1.0
In-Reply-To: <20090919233044.8361a912.akpm@linux-foundation.org>
References: <1253211850-29309-1-git-send-email-vapier@gentoo.org> 
	<20090919233044.8361a912.akpm@linux-foundation.org>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Sun, 20 Sep 2009 18:40:41 -0400
Message-ID: <8bd0f97a0909201540t25dd2337o15ebe63a2a9ca4ec@mail.gmail.com>
Subject: Re: [Uclinux-dist-devel] [PATCH] input/keyboard: new driver for 
	ADP5520 MFD PMICs
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
       Dmitry Torokhov <dmitry.torokhov@gmail.com>,
       linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
       uclinux-dist-devel@blackfin.uclinux.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1032
Lines: 27

On Sun, Sep 20, 2009 at 02:30, Andrew Morton wrote:
> On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger wrote:
>> +struct adp5520_keys {
>> +     struct input_dev *input;
>> +     struct notifier_block notifier;
>> +     struct device *master;
>> +     unsigned short keycode[ADP5520_KEYMAPSIZE];
>
> Where is ADP5520_KEYMAPSIZE defined?

all these things are in the common mfd adp5520 patch.  it introduces a
common adp5520 header.

>> +     for (i = 0; i < ADP5520_MAXKEYS; i++)
>> +             if (keymask & (1 << i))
>> +                     input_report_key(dev->input, dev->keycode[i], value);
>
> It seems odd that keycode is dimensioned with ADP5520_KEYMAPSIZE but
> here we iterate up to ADP5520_MAXKEYS.

ARRAY_SIZE() probably makes more sense
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/