Subject: Re: [PATCH] VFS: document what MAY_ACCESS means
From: Nicholas Miell <nmiell@comcast.net>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       viro@zeniv.linux.org.uk, hch@infradead.org
In-Reply-To: <20090921012933.2631.85495.stgit@paris.rdu.redhat.com>
References: <20090921012933.2631.85495.stgit@paris.rdu.redhat.com>
Content-Type: text/plain
Date: Sun, 20 Sep 2009 18:52:01 -0700
Message-Id: <1253497921.30237.1.camel@entropy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 859
Lines: 22

Since this is a documentation patch, here are some nits.

> +/*
> + * The vfs MAY_ACCESS flag really means that we might not use the object
> + * immediately (consider chdir which might not actually use the new dir).
> + * Thus permissions must be checked mmediately rather than relying on later
                                       ^ immediately
> + * checks during the actual user of the object in question.  This is an
                               ^ use
> + * internal flag and should not come from userspace.
> + */
>  #define MAY_ACCESS 16
>  #define MAY_OPEN 32

-- 
Nicholas Miell <nmiell@comcast.net>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/