Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbZIUDko (ORCPT ); Sun, 20 Sep 2009 23:40:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754018AbZIUDkm (ORCPT ); Sun, 20 Sep 2009 23:40:42 -0400 Received: from fifo99.com ([67.223.236.141]:58739 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbZIUDkl (ORCPT ); Sun, 20 Sep 2009 23:40:41 -0400 Subject: Re: [PATCH 1/12] scsi: megaraid_sas - tape drive support fix From: Daniel Walker To: "Yang, Bo" Cc: "James.Bottomley@HansenPartnership.com" , "James.Bottomley@suse.de" , "linux-scsi@vger.kernel.org" , "akpm@osdl.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <4B6A08C587958942AA3002690DD4F8C35C5123FA@cosmail02.lsi.com> References: <4B6A08C587958942AA3002690DD4F8C35C5123FA@cosmail02.lsi.com> Content-Type: text/plain Date: Sun, 20 Sep 2009 20:40:35 -0700 Message-Id: <1253504435.9654.221.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 16 Your patches all have numerous serious style problems.. There are far too many to even give a summary here, and they are all different kinds of problems.. You would need to fix all these issues before these patches could move forward. Could you run scripts/checkpatch.pl on you patches and fix all the issues that it reports? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/