Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754599AbZIUIBJ (ORCPT ); Mon, 21 Sep 2009 04:01:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753146AbZIUIBH (ORCPT ); Mon, 21 Sep 2009 04:01:07 -0400 Received: from smtpbg78.qq.com ([119.147.10.237]:42802 "HELO smtpbg78.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752380AbZIUIBG (ORCPT ); Mon, 21 Sep 2009 04:01:06 -0400 X-Greylist: delayed 404 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Sep 2009 04:01:05 EDT X-QQ-mid: esmtp3t1253519576t32t6436 Subject: [PATCH] ARM:S3C24XX: Fix a wrong dependency in Kconfig which leads to a compile time error From: Shine Liu Reply-To: shinel@foxmail.com To: ben-linux@fluff.org Cc: linux-arm-kernel@lists.arm.linux.org.uk, inux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org Content-Type: text/plain Date: Mon, 21 Sep 2009 15:52:12 +0800 Message-Id: <1253519532.5804.30.camel@shinel> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1817 Lines: 47 Hi all, There's a small mistake in arch/arm/plat-s3c24xx/Kconfig leads to a compile time error when compiling kernel for S3C24XX mach: LD .tmp_vmlinux1 arch/arm/mach-s3c2440/built-in.o: In function `mini2440_map_io': mach-mini2440.c:(.init.text+0x4a0): undefined reference to `s3c_device_nand' arch/arm/mach-s3c2440/built-in.o:(.init.data+0x78c): undefined reference to `s3c_device_nand' arch/arm/plat-s3c24xx/built-in.o: In function `s3c244x_map_io': common-smdk.c:(.init.text+0x8e4): undefined reference to `s3c_device_nand' arch/arm/plat-s3c24xx/built-in.o: In function `smdk_machine_init': common-smdk.c:(.init.text+0xe44): undefined reference to `s3c_device_nand' arch/arm/plat-s3c24xx/built-in.o:(.init.data+0x18c): undefined reference to `s3c_device_nand' make: *** [.tmp_vmlinux1] Error 1 The bug was introduced by the patch: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=db616eb67604242c11bfbb331bb143bfe4a2e386 Both kernel 2.6.31 and latest linux-next (next-20090918) has the defect. The following patch will fixed this bug. Signed-off-by: Shine Liu Signed-off-by: Shine Liu ---------------------------------------------------- --- a/arch/arm/plat-s3c24xx/Kconfig 2009-09-21 15:09:59.000000000 +0800 +++ b/arch/arm/plat-s3c24xx/Kconfig 2009-09-21 15:10:09.000000000 +0800 @@ -10,7 +10,7 @@ default y select NO_IOPORT select ARCH_REQUIRE_GPIOLIB - select S3C_DEVICE_NAND + select S3C_DEV_NAND help Base platform code for any Samsung S3C24XX device -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/