Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755297AbZIUJOH (ORCPT ); Mon, 21 Sep 2009 05:14:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753988AbZIUJOG (ORCPT ); Mon, 21 Sep 2009 05:14:06 -0400 Received: from smtp-out.google.com ([216.239.33.17]:47604 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbZIUJOF (ORCPT ); Mon, 21 Sep 2009 05:14:05 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=spVsv4sBZmB/82+knDdX+WJlZeLLwUfvRwbTX1lYXnCZfjoqqAZiahn5RC2OjdOQQ 10Fn9Ue1rr7EMb58Q81Og== Date: Mon, 21 Sep 2009 02:13:59 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton , Fenghua Yu , Tony Luck cc: ebmunson@us.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org, mtk.manpages@gmail.com, randy.dunlap@oracle.com, rth@twiddle.net, ink@jurassic.park.msu.ru, linux-ia64@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] remove duplicate asm/mman.h files In-Reply-To: <200909211031.25369.arnd@arndb.de> Message-ID: References: <200909181848.42192.arnd@arndb.de> <200909211031.25369.arnd@arndb.de> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 52 On Mon, 21 Sep 2009, Arnd Bergmann wrote: > > > -#define MCL_CURRENT 1 /* lock all current mappings */ > > > -#define MCL_FUTURE 2 /* lock all future mappings */ > > > +#define MAP_GROWSUP 0x0200 /* register stack-like segment */ > > > > > > #ifdef __KERNEL__ > > > #ifndef __ASSEMBLY__ > > > > ia64 doesn't use MAP_GROWSUP, so it's probably not necessary to carry it > > along with your cleanup. > > ia64 is the only architecture defining it, nobody uses it in the kernel. > If the ia64 maintainers want to remove it in a separate patch, that > would probably be a good idea. > I'll do it then. > I tried not to change the ABI in any way in my patch, and there is > a theoretical possibility that some user space program on ia64 currently > depends on that definition. > I don't buy that as justification, if some userspace program uses it based on the false belief that it actually does what it says, it's probably better to break their build than perpetuating the lie that it's different than ~MAP_GROWSDOWN. ia64: remove definition for MAP_GROWSUP MAP_GROWSUP is unused. Signed-off-by: David Rientjes --- diff --git a/arch/ia64/include/asm/mman.h b/arch/ia64/include/asm/mman.h --- a/arch/ia64/include/asm/mman.h +++ b/arch/ia64/include/asm/mman.h @@ -11,7 +11,6 @@ #include #define MAP_GROWSDOWN 0x00100 /* stack-like segment */ -#define MAP_GROWSUP 0x00200 /* register stack-like segment */ #define MAP_DENYWRITE 0x00800 /* ETXTBSY */ #define MAP_EXECUTABLE 0x01000 /* mark it as an executable */ #define MAP_LOCKED 0x02000 /* pages are locked */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/