Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818AbZIULM2 (ORCPT ); Mon, 21 Sep 2009 07:12:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752231AbZIULM1 (ORCPT ); Mon, 21 Sep 2009 07:12:27 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:51009 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbZIULM1 (ORCPT ); Mon, 21 Sep 2009 07:12:27 -0400 Subject: Re: [PATCH 2/4] send callback when swap slot is freed From: Pekka Enberg To: Hugh Dickins Cc: ngupta@vflare.org, Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp In-Reply-To: References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253227412-24342-3-git-send-email-ngupta@vflare.org> <1253256805.4959.8.camel@penberg-laptop> <1253260528.4959.13.camel@penberg-laptop> <1253266391.4959.15.camel@penberg-laptop> <4AB3A16B.90009@vflare.org> <4AB487FD.5060207@cs.helsinki.fi> Date: Mon, 21 Sep 2009 14:12:30 +0300 Message-Id: <1253531550.5216.32.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.24.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 20 Hi Hugh, On Mon, 2009-09-21 at 12:07 +0100, Hugh Dickins wrote: > Is the main basis for your disgust at the way that Nitin installs the > callback, that loop down the swap_info_structs? I should point out > that it was I who imposed that on Nitin: before that he was passing a > swap entry (or was it a swap type extracted from a swap entry? > I forget), which was the sole reference to a swp_entry_t in his > driver - I advised a bdev interface. The callback setup from ->read() just looks gross. However, it's your call Hugh so I'll just shut up now. ;-) Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/