Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755805AbZIUMBD (ORCPT ); Mon, 21 Sep 2009 08:01:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752838AbZIUMBB (ORCPT ); Mon, 21 Sep 2009 08:01:01 -0400 Received: from mail-bw0-f210.google.com ([209.85.218.210]:49346 "EHLO mail-bw0-f210.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbZIUMBA convert rfc822-to-8bit (ORCPT ); Mon, 21 Sep 2009 08:01:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=u7dEIq9cinMwAxcUbdn/hIdtZIdR6jVteUIu69x6uwv/OCFnL9fdUu1GgCq9akD9P5 v14Ey2cn5Y4MsZA7Twyu9Yt07CtP4NQHy2j2EionIt3NeJDNgkLBW56Z7zLOtjq7USAO zfHwcFCHeXymRSWbtNGce1/BpZsCjWGJOam+4= MIME-Version: 1.0 In-Reply-To: References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253260528.4959.13.camel@penberg-laptop> <1253266391.4959.15.camel@penberg-laptop> <4AB3A16B.90009@vflare.org> <4AB487FD.5060207@cs.helsinki.fi> <1253531550.5216.32.camel@penberg-laptop> Date: Mon, 21 Sep 2009 15:01:02 +0300 X-Google-Sender-Auth: ac10203845931b53 Message-ID: <84144f020909210501l4a216205q85523a06f4589f2a@mail.gmail.com> Subject: Re: [PATCH 2/4] send callback when swap slot is freed From: Pekka Enberg To: Hugh Dickins Cc: ngupta@vflare.org, Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 24 On Mon, Sep 21, 2009 at 2:55 PM, Hugh Dickins wrote: >> The callback setup from ->read() just looks gross. However, it's your >> call Hugh so I'll just shut up now. ;-) > > Ah, no, please don't! ?So it's _that_ end of it that's upsetting you, > and rightly so, I hadn't grasped that. Heh, right. :-) On Mon, Sep 21, 2009 at 2:55 PM, Hugh Dickins wrote: > (Nitin, your patch division is quite wrong: you should present a patch > in which your driver works, albeit poorly, without the notifier; then > a patch in which the notifier is added at the swapfile.c end and your > driver end, so we can see how they fit together.) Yes, please. Such standalone driver could go into drivers/staging for 2.6.32 probably. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/