Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756547AbZIUPIU (ORCPT ); Mon, 21 Sep 2009 11:08:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756539AbZIUPIS (ORCPT ); Mon, 21 Sep 2009 11:08:18 -0400 Received: from mail-yw0-f194.google.com ([209.85.211.194]:48012 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756344AbZIUPIO (ORCPT ); Mon, 21 Sep 2009 11:08:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=b8LL23GyZN/PRWctv87alaKATe+SNTCy4U+9+tOu/CIRkG8IDyIlFf/h38vpCVO4my vyRdGTfwRKVW2+NUy786A68xZeqZKFW258U3IQdoFivOS8UsPcuw/jCVgAFiXDdki+wC ODHCsDgRfT3xSimqwivbE1vksOtnHlB3HMnTQ= MIME-Version: 1.0 Date: Tue, 22 Sep 2009 00:00:51 +0900 Message-ID: <2f11576a0909210800l639560e4jad6cfc2e7f74538f@mail.gmail.com> Subject: a patch drop request in -mm From: KOSAKI Motohiro To: Andrew Morton , Mel Gorman , Christoph Lameter , Johannes Weiner , LKML , linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 49 Mel, Today, my test found following patch makes false-positive warning. because, truncate can free the pages although the pages are mlock()ed. So, I think following patch should be dropped. .. or, do you think truncate should clear PG_mlock before free the page? Can I ask your patch intention? ============================================================= commit 7a06930af46eb39351cbcdc1ab98701259f9a72c Author: Mel Gorman Date: Tue Aug 25 00:43:07 2009 +0200 When a page is freed with the PG_mlocked set, it is considered an unexpected but recoverable situation. A counter records how often this event happens but it is easy to miss that this event has occured at all. This patch warns once when PG_mlocked is set to prompt debuggers to check the counter to see how often it is happening. Signed-off-by: Mel Gorman Reviewed-by: Christoph Lameter Acked-by: Johannes Weiner Signed-off-by: Andrew Morton diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 28c2f3e..251fd73 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -494,6 +494,11 @@ static inline void __free_one_page(struct page *page, */ static inline void free_page_mlock(struct page *page) { + WARN_ONCE(1, KERN_WARNING + "Page flag mlocked set for process %s at pfn:%05lx\n" + "page:%p flags:%#lx\n", + current->comm, page_to_pfn(page), + page, page->flags|__PG_MLOCKED); __dec_zone_page_state(page, NR_MLOCK); __count_vm_event(UNEVICTABLE_MLOCKFREED); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/