Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756601AbZIUPXR (ORCPT ); Mon, 21 Sep 2009 11:23:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756569AbZIUPXQ (ORCPT ); Mon, 21 Sep 2009 11:23:16 -0400 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:47474 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756554AbZIUPXP convert rfc822-to-8bit (ORCPT ); Mon, 21 Sep 2009 11:23:15 -0400 From: "Yang, Bo" To: Daniel Walker CC: "James.Bottomley@HansenPartnership.com" , "James.Bottomley@suse.de" , "linux-scsi@vger.kernel.org" , "akpm@osdl.org" , "linux-kernel@vger.kernel.org" Date: Mon, 21 Sep 2009 09:22:44 -0600 Subject: RE: [PATCH 1/12] scsi: megaraid_sas - tape drive support fix Thread-Topic: [PATCH 1/12] scsi: megaraid_sas - tape drive support fix Thread-Index: Aco6bVLHfVaqSigWRHyr4yd6+7QYowAYVYnA Message-ID: <4B6A08C587958942AA3002690DD4F8C35C5124EB@cosmail02.lsi.com> References: <4B6A08C587958942AA3002690DD4F8C35C5123FA@cosmail02.lsi.com> <1253504435.9654.221.camel@desktop> In-Reply-To: <1253504435.9654.221.camel@desktop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 31 Daniel, Thanks for viewing the patches. I did run the checkpatch.pl first before I submit the patches. Is there possible you can tell me the errors in the specific patch, I need to find out if it is my e-mail setting problems or something else. Thanks, Bo Yang -----Original Message----- From: Daniel Walker [mailto:dwalker@fifo99.com] Sent: Sunday, September 20, 2009 11:41 PM To: Yang, Bo Cc: James.Bottomley@HansenPartnership.com; James.Bottomley@suse.de; linux-scsi@vger.kernel.org; akpm@osdl.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/12] scsi: megaraid_sas - tape drive support fix Your patches all have numerous serious style problems.. There are far too many to even give a summary here, and they are all different kinds of problems.. You would need to fix all these issues before these patches could move forward. Could you run scripts/checkpatch.pl on you patches and fix all the issues that it reports? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/