Message-ID: <4AB7AAF9.3070805@petalogix.com>
Date: Mon, 21 Sep 2009 18:34:01 +0200
From: Michal Simek <monstr@monstr.eu>
Reply-To: michal.simek@petalogix.com
User-Agent: Thunderbird 2.0.0.22 (X11/20090625)
MIME-Version: 1.0
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
CC: linux-kernel@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd
 memory:" message on microblaze.
References: <20090915165037.GA23702@csclub.uwaterloo.ca> <20090917154623.GD23702@csclub.uwaterloo.ca> <20090917154706.GE23702@csclub.uwaterloo.ca> <4AB773F6.7090901@petalogix.com> <20090921133203.GZ23700@csclub.uwaterloo.ca>
In-Reply-To: <20090921133203.GZ23700@csclub.uwaterloo.ca>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1535
Lines: 48

Lennart Sorensen wrote:
> On Mon, Sep 21, 2009 at 02:39:18PM +0200, Michal Simek wrote:
>> Added to next branch.
>>
>> There were some problems which I fixed.
>> 1. long first description
>> 2. missing microblaze: at the beginning

I want to have "microblaze:" at the beginning of email/commit message.
It is much clear for mailing list, Linus and me.

Thanks,
Michal

> 
> Missing what?
> 
>> 3. line longer than 80chars
> 
> Hmm, I thought for sure I had checkpatch.pl claiming all my lines
> were OK.  Odd.  Clearly the one below is longer though.  How strange.
> 
>> Lennart Sorensen wrote:
>>> Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
>>> claimed rather than number of pages.
>>>
>>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
>>>
>>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>>> index f207f1a..ed5f96b 100644
>>> --- a/arch/microblaze/mm/init.c
>>> +++ b/arch/microblaze/mm/init.c
>>> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>>>  		totalram_pages++;
>>>  		pages++;
>>>  	}
>>> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>>> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>>>  }
>>>  #endif
>>>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/