Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbZIUSAf (ORCPT ); Mon, 21 Sep 2009 14:00:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752180AbZIUSAd (ORCPT ); Mon, 21 Sep 2009 14:00:33 -0400 Received: from casper.infradead.org ([85.118.1.10]:53378 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbZIUSAc (ORCPT ); Mon, 21 Sep 2009 14:00:32 -0400 Date: Mon, 21 Sep 2009 20:00:42 +0200 From: Arjan van de Ven To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker , mingo@elte.hu Subject: Re: TRACE_EVENT_ABI ? Message-ID: <20090921200042.29f0cf49@infradead.org> In-Reply-To: <1253551567.2630.26.camel@frodo> References: <20090921093652.0722d745@infradead.org> <20090921152853.2f8c0597@infradead.org> <1253551567.2630.26.camel@frodo> Organization: Intel X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 56 On Mon, 21 Sep 2009 12:46:07 -0400 Steven Rostedt wrote: > On Mon, 2009-09-21 at 15:28 +0200, Arjan van de Ven wrote: > > On Mon, 21 Sep 2009 09:26:41 -0400 (EDT) > > Steven Rostedt wrote: > > > > > > > > [ Resending due to wrong SMTP server ] > > > > > > > > > On Mon, 21 Sep 2009, Arjan van de Ven wrote: > > > > > > > Hi, > > > > > > > > Ingo suggested to make a TRACE_EVENT_ABI, which is equivalent in > > > > implementation to TRACE_EVENT, except that it signals a stable > > > > interface. > > > > > > > > In trying to implement this I'm running into a wall where > > > > TRACE_EVENT keeps being defined in many different ways all over > > > > the place, making this a really nasty hack to make it just an > > > > alias. > > > > > > > > Do you have any clever ideas on how to make this an alias > > > > without fouling up the whole tracing system? > > > > > > > > > > I don't know what you've done so far, but can't you simply in > > > tracepoint.h define: > > > > > > #define TRACE_EVENT_API(a,b,c,d,e) TRACE_EVENT(a,b,c,d,e) > > > > unfortunately, due to the preprocessor trickery around TRACE_EVENT > > this completely barfs. > > I forgot to tell you about PARAMS. > > This patch compiled for me; > your magic skills exceed mine ;-) mind sending me a signoff for this ? -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/