Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbZIUTpS (ORCPT ); Mon, 21 Sep 2009 15:45:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753385AbZIUTpP (ORCPT ); Mon, 21 Sep 2009 15:45:15 -0400 Received: from brick.kernel.dk ([93.163.65.50]:44247 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753379AbZIUTpP (ORCPT ); Mon, 21 Sep 2009 15:45:15 -0400 Date: Mon, 21 Sep 2009 21:45:18 +0200 From: Jens Axboe To: "Martin K. Petersen" Cc: device-mapper development , Mike Snitzer , Alasdair G Kergon , linux-kernel@vger.kernel.org Subject: Re: [dm-devel] [PATCH 1/3] block: Add blk_queue_copy_limits() Message-ID: <20090921194518.GJ23126@kernel.dk> References: <4AB3B43D.9000802@ce.jp.nec.com> <4AB4F74E.7000908@ce.jp.nec.com> <4AB7AAE2.8000404@ce.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 20 On Mon, Sep 21 2009, Martin K. Petersen wrote: > >>>>> "Jun'ichi" == Jun'ichi Nomura writes: > > Jun'ichi> If we aren't sure, shouldn't we set its default to -1 or > Jun'ichi> putting comments in blk_set_default_limits() at least to avoid > Jun'ichi> possible confusion in future? > > Jens, what do you think about this? Goes on top of what you have > queued... Look sane, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/