Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbZIVGKU (ORCPT ); Tue, 22 Sep 2009 02:10:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751790AbZIVGKT (ORCPT ); Tue, 22 Sep 2009 02:10:19 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:57914 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751513AbZIVGKS (ORCPT ); Tue, 22 Sep 2009 02:10:18 -0400 Message-ID: <4AB86A03.7060207@cn.fujitsu.com> Date: Tue, 22 Sep 2009 14:09:07 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Zdenek Kabelac CC: Linux Kernel Mailing List , mbroz@redhat.com, tytso@mit.edu, jens.axboe@oracle.com, mingo@elte.hu Subject: Re: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with blk_trace_init_sysfs References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 31 Zdenek Kabelac wrote: > Subject: [PATCH] Add missing blk_trace_remove_sysfs to be in pair with > blk_trace_init_sysfs > From: Zdenek Kabelac > > Adds missing blk_trace_remove_sysfs() to be in pair with > blk_trace_init_sysfs() introduced in commit > 1d54ad6da9192fed5dd3b60224d9f2dfea0dcd82. > > Problem was noticed via kmemleak backtrace when some sysfs entries > were note properly destroyed during device removal: > Thanks for reporting and fixing this! > @@ -465,6 +466,7 @@ void blk_unregister_queue(struct gendisk *disk) > > kobject_uevent(&q->kobj, KOBJ_REMOVE); > kobject_del(&q->kobj); > + blk_trace_remove_sysfs(disk_to_dev(disk)); This should be moved outside of 'if'. > kobject_put(&disk_to_dev(disk)->kobj); > } > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/