Date: Tue, 22 Sep 2009 09:37:18 +0200
From: Sam Ravnborg <sam@ravnborg.org>
To: Chen Liqin <liqin.chen@sunplusct.com>
Cc: Tim Abbott <tabbott@ksplice.com>, linux-kernel@vger.kernel.org,
       linux-arch@vger.kernel.org, liqin.gnu@gmail.com
Subject: Re: [PATCH 1/2] score: add head files define in vmlinux.lds.S
Message-ID: <20090922073718.GA29384@merkur.ravnborg.org>
References: <1253601122.27225.2.camel@ad3ser01>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1253601122.27225.2.camel@ad3ser01>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1250
Lines: 41

On Tue, Sep 22, 2009 at 02:32:02PM +0800, Chen Liqin wrote:
> 
> Signed-off-by: Chen Liqin <liqin.chen@sunplusct.com>
> ---
>  arch/score/kernel/vmlinux.lds.S |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/score/kernel/vmlinux.lds.S b/arch/score/kernel/vmlinux.lds.S
> index aab4703..eebcbaa 100644
> --- a/arch/score/kernel/vmlinux.lds.S
> +++ b/arch/score/kernel/vmlinux.lds.S
> @@ -24,6 +24,8 @@
>   */
>  
>  #include <asm-generic/vmlinux.lds.h>
> +#include <asm/thread_info.h>
> +#include <asm/page.h>
>  
>  OUTPUT_ARCH(score)
>  ENTRY(_stext)

Hi Chen.

I assume this is needed to allow Tim's patchset to build.
The preferred way is that you integrate this into the original
patch and apply it to your tree.

We prefer arch specific patches to go in via the arch trees.

I sometime takes patches in via kbuild that touches a lot
of architectures but stuff like like should go in
via you.

For score (and for other archs) I cannot even build test stuff..

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/