Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754246AbZIVH4L (ORCPT ); Tue, 22 Sep 2009 03:56:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752756AbZIVH4J (ORCPT ); Tue, 22 Sep 2009 03:56:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58542 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753327AbZIVH4I (ORCPT ); Tue, 22 Sep 2009 03:56:08 -0400 Date: Tue, 22 Sep 2009 09:56:11 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@wotan.suse.de To: "Hennerich, Michael" Cc: Dmitry Torokhov , Mike Frysinger , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, Bryan Wu Subject: RE: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs In-Reply-To: <8A42379416420646B9BFAC9682273B6D0DFAD237@limkexm3.ad.analog.com> Message-ID: References: <1253211850-29309-1-git-send-email-vapier@gentoo.org> <20090922055954.GB9658@core.coreip.homeip.net> <8A42379416420646B9BFAC9682273B6D0DFAD237@limkexm3.ad.analog.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 30 On Tue, 22 Sep 2009, Hennerich, Michael wrote: > >It actually doesn't seem to be the same condition (KP_INT vs. KR_INT), > >but it's difficult to say, as these constants are apparently added in > >some other patch I have no idea about. > > KP Key-Press versus Key-Release > > >And the same for other constants used in the code ... the patch seems to > >be quite incomplete. > > The missing constants are in include/linux/mfd/adp5520.h > > This file was sent in a different patch, adding support for the Multi Function Device Core > (drivers/mfd/adp5520.c) The dependency on another patch should be either at least expressed in the patch Changelog, or even better send the patches as series with proper numbering, so that the dependency is obvious. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/