From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2)
Date: Tue, 22 Sep 2009 21:51:35 +0200
User-Agent: KMail/1.12.1 (Linux/2.6.31-rjw; KDE/4.3.1; x86_64; ; )
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
       LKML <linux-kernel@vger.kernel.org>,
       Linux PCI <linux-pci@vger.kernel.org>,
       pm list <linux-pm@lists.linux-foundation.org>
References: <200909212337.01812.rjw@sisk.pl> <20090922091620.599ab046@infradead.org>
In-Reply-To: <20090922091620.599ab046@infradead.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200909222151.36022.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1012
Lines: 25

On Tuesday 22 September 2009, Arjan van de Ven wrote:
> On Mon, 21 Sep 2009 23:37:01 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> >  
> > -	dev->current_state = state;
> > +	pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
> > +	dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK);
> > +	/* Return error code if we have failed to change the state */
> > +	if (dev->current_state != state)
> > +		dev_info(&dev->dev, "Refused to change power state, "
> > +			"currently in D%d\n", dev->current_state);
> 
> I would suspect that you want this message only once...
> to avoid it flooding logs and such

Hmm?  I don't think we use pci_set_power_state() _that_ often.

> or at least ratelimiting it

That sounds like a good idea, though, will respin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/