Date: Tue, 22 Sep 2009 14:19:14 -0700 (PDT)
Message-Id: <20090922.141914.61481427.davem@davemloft.net>
To: cernekee@gmail.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] kaweth: Fix memory leak in kaweth_control()
From: David Miller <davem@davemloft.net>
In-Reply-To: <6a1f935a6229adafb68d0e1ca7bc71fa@localhost>
References: <6a1f935a6229adafb68d0e1ca7bc71fa@localhost>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1020
Lines: 27

From: Kevin Cernekee <cernekee@gmail.com>
Date: Fri, 18 Sep 2009 18:43:30 -0700

> kaweth_control() never frees the buffer that it allocates for the USB
> control message.  Test case:
> 
> while :; do ifconfig eth2 down ; ifconfig eth2 up ; done
> 
> This is a tiny buffer so it is a slow leak.  If you want to speed up the
> process, you can change the allocation size to e.g. 16384 bytes, and it
> will consume several megabytes within a few minutes.
> 
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>

Applied, thanks.

I've been trying to wait to give time for people like david-b
to review and bless the various USB networking patches that have
been posted over the past few weeks but I'm running out of
patience :-)

So simple ones like this I'm just gonna apply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/