Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753647AbZIWBBr (ORCPT ); Tue, 22 Sep 2009 21:01:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753599AbZIWBBq (ORCPT ); Tue, 22 Sep 2009 21:01:46 -0400 Received: from mail.perches.com ([173.55.12.10]:1135 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753598AbZIWBBq (ORCPT ); Tue, 22 Sep 2009 21:01:46 -0400 Subject: Re: checkpatch as a tool (was Re: [RFC][PATCH] SCHED_EDF scheduling class) From: Joe Perches To: Daniel Walker Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Steven Rostedt In-Reply-To: <1253667103.25689.35.camel@desktop> References: <1253615424.20345.76.camel@Palantir> <1253625878.6575.34.camel@desktop> <1253628061.20345.173.camel@Palantir> <1253637721.18939.3.camel@laptop> <20090922191117.GB24542@elte.hu> <1253667103.25689.35.camel@desktop> Content-Type: text/plain; charset="UTF-8" Date: Tue, 22 Sep 2009 18:01:48 -0700 Message-Id: <1253667708.30020.134.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 569 Lines: 18 On Tue, 2009-09-22 at 17:51 -0700, Daniel Walker wrote: > I'll stop sending those > emails if it's actually negative , but I don't think it is.. Hi Daniel. I think it'd be more helpful if instead of merely sending a "hah! checkpatch failure!" email you send the submitter a gentler nudge and a fixed patch. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/