Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbZIWHTY (ORCPT ); Wed, 23 Sep 2009 03:19:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754307AbZIWHTX (ORCPT ); Wed, 23 Sep 2009 03:19:23 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40471 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754327AbZIWHTW (ORCPT ); Wed, 23 Sep 2009 03:19:22 -0400 Date: Wed, 23 Sep 2009 09:18:57 +0200 From: Pavel Machek To: Jonathan Cameron Cc: Zhang Rui , Linux Kernel Mailing List , linux-acpi , Jean Delvare , "alan@linux.intel.com" , Len Brown , "Cory T. Tusar" , "Trisal, Kalhan" Subject: Re: [RFC] [PATCH 1/2] introduce ALS sysfs class Message-ID: <20090923071857.GC8565@elf.ucw.cz> References: <1253590755.15763.21.camel@rzhang-dt> <4AB8C62F.5020605@cam.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AB8C62F.5020605@cam.ac.uk> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 30 On Tue 2009-09-22 13:42:23, Jonathan Cameron wrote: > Zhang Rui wrote: > > Hi, Jonathan, > > > > this is the refresh ALS sysfs class driver. > > I just introduced one sysfs attribute "illuminance", because > > I didn't catch the exact meaning of the others like "???infrared". > > So it would be great if you can generate an incremental patch > > to introduce the other optional attributes needed, and update > > the documentation as well. :) > Will do, though may just leave it out of first pass of drivers > (as it may be controversial and it would be nice to get something > in place before the arguments begin!) > > All looks nice and clean. The only real question is whether > we want to standardize naming of devices under sysfs (like hwmon does) > or allow the individual drivers to do the naming? Allow the drivers to do the naming. Having useless name like "als0", with als0/name telling me what the driver is is bad. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/