Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751073AbZIWJzx (ORCPT ); Wed, 23 Sep 2009 05:55:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750766AbZIWJzx (ORCPT ); Wed, 23 Sep 2009 05:55:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbZIWJzw (ORCPT ); Wed, 23 Sep 2009 05:55:52 -0400 Message-ID: <4AB9F08E.1020106@redhat.com> Date: Wed, 23 Sep 2009 12:55:26 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Mike Galbraith CC: Arnaldo Carvalho de Melo , rostedt@goodmis.org, LKML , Ingo Molnar , Mathieu Desnoyers , Peter Zijlstra , Frederic Weisbecker , Thomas Gleixner , Masami Hiramatsu Subject: Re: [patch] Re: [perf] Finding uninstalled modules Was Re: mailing list for trace users References: <1253132182.20020.242.camel@gandalf.stny.rr.com> <4AB89520.2050900@redhat.com> <1253618894.13917.18.camel@marge.simson.net> <4AB8B65F.7030602@redhat.com> <1253620041.13917.24.camel@marge.simson.net> <4AB8BA37.4010305@redhat.com> <20090922201746.GH5216@ghostprotocols.net> <4AB9DCC8.5050603@redhat.com> <1253697658.11461.36.camel@marge.simson.net> In-Reply-To: <1253697658.11461.36.camel@marge.simson.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 48 On 09/23/2009 12:20 PM, Mike Galbraith wrote: > > Yup, brown baggie variety. Oh darn. > > perf_counter tools: fix brown baggie module symbol loading bug. > > If there are no modules currently loaded, or the last module scanned is not > loaded, dso__load_modules() steps on the value from dso__load_vmlinux(), so > we happily load the kallsyms symbols on top of what we've already loaded. > > Fix that such that the total count of symbols loaded is returned. Should > module symbol load fail after parsing of vmlinux, is's a hard failure, so > do not silently fall-back to kallsyms. > > Still fails, but differently. Now 'annotate -k ... -m -v -v' doesn't list vmx_vcpu_run at all, even though it's prominent in 'perf top'. In addition to applying your patch I've merged current linus, so that may have introduced the problem. If I don't supply -k -m, I get $ perf annotate -v -v vmx_vcpu_run | grep vmx_vcpu new symbol: ffffffffa006f596 [0000dead]: vmx_vcpu_run [kvm_intel], hist: (nil), obj_start: (nil) new symbol: ffffffffa007025f [0000dead]: vmx_vcpu_put [kvm_intel], hist: (nil), obj_start: (nil) new symbol: ffffffffa0070bf6 [0000dead]: vmx_vcpu_load [kvm_intel], hist: (nil), obj_start: (nil) new symbol: ffffffffa0070d99 [0000dead]: vmx_vcpu_reset [kvm_intel], hist: (nil), obj_start: (nil) ffffffffa006f596-ffffffffa006fb73 vmx_vcpu_run [kvm_intel] ffffffffa007025f-ffffffffa007026e vmx_vcpu_put [kvm_intel] ffffffffa0070bf6-ffffffffa0070d98 vmx_vcpu_load [kvm_intel] ffffffffa0070d99-ffffffffa0071191 vmx_vcpu_reset [kvm_intel] Error: symbol 'vmx_vcpu_run' not present amongst the samples. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/