Date: Wed, 23 Sep 2009 16:38:15 +0200
From: Wolfram Sang <w.sang@pengutronix.de>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org,
       Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [RFC] regulator: add driver for MAX8660/8661
Message-ID: <20090923143815.GC3131@pengutronix.de>
References: <1253625499-9314-1-git-send-email-w.sang@pengutronix.de> <1253629577.11624.278.camel@vega>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="0vzXIDBeUiKkjNJl"
Content-Disposition: inline
In-Reply-To: <1253629577.11624.278.camel@vega>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2371
Lines: 74


--0vzXIDBeUiKkjNJl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Liam,

> Fwiw, the WM8350 has several similar boot up modes. Luckily we can read
> back this device to determine mode and any boot loader config. It may
> also be required to add any shadow register changes to your
> platform_data. i.e. if boot loader does any writes.

While I thought about how to achieve that (Specify voltages and convert them
back to selector-values? Ask for the selector value? Enforce a complete
register set?), I concluded that there are lots of details in here, and I'd
spare that for the case when it is actually needed. In our case, it is not.

> Btw, have you tried register read back ? The data sheet mentions a
> "bidirectional" I2C SDA line implying the device registers can be read
> back, even though they are all marked W in the register map.

The line itself has the capability of being bidirectional, still the chips =
has
no logic for being read. Page 37 states:

"The MAX8660/MAX8661 are write-only devices and recognize the 'write byte'
protocol as defined in the SMBus specification and shown in section A of Fi=
gure
11..."

And to be very sure, I just tried a read -> '-EIO'


>=20
> > +The Target Voltage 2 Registers for V3, V4 and V5 are not used by this =
driver.
> > +
> > +Note that disabling V3 or V4 has no effect if pin EN34 is driven high =
(pin and
> > +register are ORed, see datasheet).
> > +
>=20
> Sounds like EN34 status should be in platform_data.

Good idea, will implement that.

Regards,

   Wolfram

--=20
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

--0vzXIDBeUiKkjNJl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkq6MtcACgkQD27XaX1/VRutcQCfQVf9C9MrN7GcAimvUHnvEzVA
chcAoJ/H5rjDzGK8Yj51+2NxaaiQat36
=nxMg
-----END PGP SIGNATURE-----

--0vzXIDBeUiKkjNJl--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/