From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 2/2] tracing/workqueue: Rename workqueue_execute to worklet_entry and add worklet_exit
Cc: kosaki.motohiro@jp.fujitsu.com, Anton Blanchard <anton@samba.org>,
       Li Zefan <lizf@cn.fujitsu.com>, Zhaolei <zhaolei@cn.fujitsu.com>,
       Lai Jiangshan <laijs@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
       Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
In-Reply-To: <20090922203414.GA5059@nowhere>
References: <20090922024232.GC31801@kryten> <20090922203414.GA5059@nowhere>
Message-Id: <20090924092023.B645.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Thu, 24 Sep 2009 09:22:37 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1373
Lines: 44

Hi

> In Kosaki's patch, we had the work struct address displayed too.
> Your version is supposed to be sufficient because we know a workqueue
> serializes its works. Then we know that an exit event will always follow
> and match the previous entry event from the same workqueue thread.
> The workqueue pid then provides a sufficient key for that.
> 
> That said, we should worry about possible lost events from
> perf in some circumstances. And userspace profiling needs something
> to ensure the accuracy about this entry/exit pair.
> 
> We could have:
> 	entry work1
> 	exit work 1 <--- lost event
> 	entry work2 <--- lost event
> 	exit work2
> 
> And then the pair would be misinterpreted.
> 
> (Although we could have even other misinterpretation
> with other kind of scenarios, even if we have this work
> address. But that's still more safety).
> 
> So I'd prefer to keep Kosaki's idea about these keys.
> But I prefer your event naming.
> 
> May be I can unearth Kosaki's patch, change it with your naming
> and add your Signed-off-by?
> 
> Kosaki, no problem about it?

Sure.
Thank you paid attention my patch :-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/