Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbZIXFDB (ORCPT ); Thu, 24 Sep 2009 01:03:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751381AbZIXFDB (ORCPT ); Thu, 24 Sep 2009 01:03:01 -0400 Received: from mail-px0-f194.google.com ([209.85.216.194]:40912 "EHLO mail-px0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbZIXFDA (ORCPT ); Thu, 24 Sep 2009 01:03:00 -0400 MIME-Version: 1.0 In-Reply-To: <20090924125000.d734a7b1.kamezawa.hiroyu@jp.fujitsu.com> References: <1253540040-24860-1-git-send-email-ngupta@vflare.org> <20090924104708.4f54ce4e.kamezawa.hiroyu@jp.fujitsu.com> <4ABAE340.7010403@vflare.org> <20090924125000.d734a7b1.kamezawa.hiroyu@jp.fujitsu.com> Date: Thu, 24 Sep 2009 10:33:04 +0530 Message-ID: Subject: Re: [PATCH RFC 1/2] Add notifiers for various swap events From: Nitin Gupta To: KAMEZAWA Hiroyuki Cc: Hugh Dickins , Pekka Enberg , linux-kernel , linux-mm Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 33 On Thu, Sep 24, 2009 at 9:20 AM, KAMEZAWA Hiroyuki wrote: >> > >> > In general, notifier chain codes allowed to return NOTIFY_BAD. >> > But this patch just assumes all chains should return NOTIFY_OK or >> > just ignore return code. >> > >> > That's not good as generic interface, I think. >> >> >> What action we can take here if the notifier_call_chain() returns an error (apart >> from maybe printing an error)? Perhaps we can add a warning in case of swapon/off >> events but not in case of swap slot free event which is called under swap_lock. >> > If return code is ignored, please add commentary at least. > okay. > I wonder I may able to move memcg's swap_cgroup code for swapon/swapoff onto this > notifier. (swap_cgroup_swapon/swap_cgroup_swapoff) But it seems not. > sorry for bothering you. > Thanks for your comments! Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/