Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbZIXNRh (ORCPT ); Thu, 24 Sep 2009 09:17:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751693AbZIXNRg (ORCPT ); Thu, 24 Sep 2009 09:17:36 -0400 Received: from brick.kernel.dk ([93.163.65.50]:52851 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018AbZIXNRf (ORCPT ); Thu, 24 Sep 2009 09:17:35 -0400 Date: Thu, 24 Sep 2009 15:17:39 +0200 From: Jens Axboe To: Shaohua Li Cc: "Wu, Fengguang" , lkml , Peter Zijlstra , Andrew Morton , Chris Mason , Jan Kara , "linux-fsdevel@vger.kernel.org" Subject: Re: [RFC] page-writeback: move indoes from one superblock together Message-ID: <20090924131738.GG23126@kernel.dk> References: <1253775260.10618.10.camel@sli10-desk.sh.intel.com> <20090924071415.GA20808@localhost> <20090924074431.GA22396@sli10-desk.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090924074431.GA22396@sli10-desk.sh.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1456 Lines: 48 > > Could just reuse inode. > oops, forgot to remove it when moveing inode to global. This is the one I merged. I added the below as wel, we don't need to reiterate the list if we only moved inodes from a single super block. diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index b27406d..225c731 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -336,17 +336,27 @@ static void move_expired_inodes(struct list_head *delaying_queue, { LIST_HEAD(tmp); struct list_head *pos, *node; - struct super_block *sb; + struct super_block *sb = NULL; struct inode *inode; + int do_sb_sort = 0; while (!list_empty(delaying_queue)) { inode = list_entry(delaying_queue->prev, struct inode, i_list); if (older_than_this && inode_dirtied_after(inode, *older_than_this)) break; + if (sb && sb != inode->i_sb) + do_sb_sort = 1; + sb = inode->i_sb; list_move(&inode->i_list, &tmp); } + /* just one sb in list, splice to dispatch_queue and we're done */ + if (!do_sb_sort) { + list_splice(&tmp, dispatch_queue); + return; + } + /* Move inodes from one superblock together */ while (!list_empty(&tmp)) { inode = list_entry(tmp.prev, struct inode, i_list); -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/