Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbZIXNwG (ORCPT ); Thu, 24 Sep 2009 09:52:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752492AbZIXNwF (ORCPT ); Thu, 24 Sep 2009 09:52:05 -0400 Received: from casper.infradead.org ([85.118.1.10]:32942 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752370AbZIXNwE (ORCPT ); Thu, 24 Sep 2009 09:52:04 -0400 Date: Thu, 24 Sep 2009 15:52:17 +0200 From: Arjan van de Ven To: Wu Fengguang Cc: Jens Axboe , "Li, Shaohua" , lkml , Peter Zijlstra , Andrew Morton , Chris Mason , "linux-fsdevel@vger.kernel.org" , Jan Kara Subject: Re: [RFC] page-writeback: move indoes from one superblock together Message-ID: <20090924155217.5ad0de4b@infradead.org> In-Reply-To: <20090924134625.GA2507@localhost> References: <1253775260.10618.10.camel@sli10-desk.sh.intel.com> <20090924100136.GA25778@localhost> <20090924123519.GF23126@kernel.dk> <20090924132252.GA696@localhost> <20090924132949.GH23126@kernel.dk> <20090924134625.GA2507@localhost> Organization: Intel X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 25 On Thu, 24 Sep 2009 21:46:25 +0800 Wu Fengguang wrote: > > Note that dirty_time may not be unique, so need some workaround. And > the resulted rbtree implementation may not be more efficient than > several list traversals even for a very large list (as long as > superblocks numbers are low). > > The good side is, once sb+dirty_time rbtree is implemented, it should > be trivial to switch the key to sb+inode_number (also may not be > unique), and to do location ordered writeback ;) would you want to sort by dirty time, or by inode number? (assuming inode number is loosely related to location on disk) -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/