Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbZIXRi4 (ORCPT ); Thu, 24 Sep 2009 13:38:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752882AbZIXRiy (ORCPT ); Thu, 24 Sep 2009 13:38:54 -0400 Received: from hq-exedge.brocade.com ([66.243.153.82]:38389 "EHLO hq-exedge.brocade.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbZIXRix convert rfc822-to-8bit (ORCPT ); Thu, 24 Sep 2009 13:38:53 -0400 From: Jing Huang To: Daniel Walker CC: "James.Bottomley@HansenPartnership.com" , Krishna Gudipati , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Ramkumar Vadivelu , Vinodh Ravindran Date: Thu, 24 Sep 2009 10:38:53 -0700 Subject: RE: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1) Thread-Topic: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1) Thread-Index: Aco9LeNSxe6uLJJIRsObI5MmoYGmrQAD78Yg Message-ID: References: <200909240049.n8O0nw3l013437@swe58.brocade.com> <1253807042.20648.188.camel@desktop> In-Reply-To: <1253807042.20648.188.camel@desktop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1539 Lines: 41 > On Wed, 2009-09-23 at 17:49 -0700, Jing Huang wrote: > > + > > + return (*(union bfi_addr_u *) &addr); > > +} > > Have you run checkpatch on this code? It produces many errors due to > your "return" usage for one.. The usual style of return is not to use > parentheses since it's really not a function .. > > The line I quoted above gives the following error, > > ERROR: return is not a function, parentheses are not required > #266: FILE: drivers/scsi/bfa/bfa_cb_ioim_macros.h:132: > + return (*(union bfi_addr_u *) &addr); > > First of all I'd consider making your code consistent with respect to > the return statements .. I noticed that you sometimes use the > parentheses sometimes not .. Since it's more with Linux style I'd just > remove all the extra parentheses.. > > Checkpatch produces many other errors in your code .. If you haven't > already evaluated those errors, I'd do go through each patch and review > the errors (and the warnings) that it produces since checkpatch can give > you a fairly mechanical view into how well your code matches the Linux > coding style. The less the output from checkpatch the better .. > > Daniel > Hi Daniel, I did run checkpatch.pl and it didn't report any ERROR or WARNING. Do you use any specific flags? Thanks Jing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/