Date: Thu, 24 Sep 2009 20:07:27 +0200
From: Wolfram Sang <w.sang@pengutronix.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] regulator: add driver for MAX8660/8661
Message-ID: <20090924180727.GA6408@pengutronix.de>
References: <1253798645-9493-1-git-send-email-w.sang@pengutronix.de> <20090924173904.GA9082@sirena.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK"
Content-Disposition: inline
In-Reply-To: <20090924173904.GA9082@sirena.org.uk>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1974
Lines: 61


--YZ5djTAD1cGYuMQK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > +	if (MAX8660_DCDC_MIN_UV + selector * MAX8660_DCDC_STEP > max_uV)
> > +		return -EINVAL;
>=20
> Not important but using list_voltage() here would be a little nicer.

Well, uhm, yeah :)

> > +static struct regulator_ops max8660_dcdc_ops =3D {
> > +	.is_enabled =3D max8660_dcdc_is_enabled,
> > +	.list_voltage =3D max8660_dcdc_list,
> > +	.set_voltage =3D max8660_dcdc_set,
> > +	.get_voltage =3D max8660_dcdc_get,
> > +	/* no set_mode() & friends: forced PWM does not save any power */
>=20
> Forced PWM is normally a power loss - the benefit it gives is the
> ability to respond to sudden spikes in load without voltage droops.  The
> power benefit from not having it enabled is usually only apparent at
> lower loads.

Understood. Well, as this chip automatically switches PWM on/off depending =
on
the load (formula is in the datasheet), it seems to me that the forced-PWM =
mode
is mainly used for systems which prefer low-noise on the signal. So, the ab=
ove
comment could just be dropped. Liam, could you do this, or shall I resend?

Regards,

   Wolfram

--=20
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

--YZ5djTAD1cGYuMQK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkq7tV8ACgkQD27XaX1/VRuiMgCgtrMkTgt1pjusl1eros85Z6cZ
k6IAn0/2dqbol7/ToE/cmQMjXFeCWLSC
=XJBS
-----END PGP SIGNATURE-----

--YZ5djTAD1cGYuMQK--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/