Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbZIYOE4 (ORCPT ); Fri, 25 Sep 2009 10:04:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752612AbZIYOEz (ORCPT ); Fri, 25 Sep 2009 10:04:55 -0400 Received: from casper.infradead.org ([85.118.1.10]:42124 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbZIYOEz (ORCPT ); Fri, 25 Sep 2009 10:04:55 -0400 Date: Fri, 25 Sep 2009 16:05:01 +0200 From: Arjan van de Ven To: Borislav Petkov Cc: Mauro Carvalho Chehab , bluesmoke-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH 17/63] edac_mce: Add an interface driver to report mce errors via edac Message-ID: <20090925160501.03a0f37d@infradead.org> In-Reply-To: <20090925135626.GA8145@aftab> References: <20090924192727.212ce46f@pedra.chehab.org> <20090925094855.GA29551@aftab> <20090925091130.14135879@pedra.chehab.org> <20090925135626.GA8145@aftab> Organization: Intel X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 23 On Fri, 25 Sep 2009 15:56:26 +0200 > > 1) edac_mce is not a module (see patch 18). So, just calling a > > routine on edac_mce should be safe, even at NMI; > > no, I mean the ->check_error member - it could call into a module if > i7core_edac is compiled as such. calling modular code from NMI is not a fatal event though. calling printk or taking spinlocks otoh.. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/