Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbZIZIRI (ORCPT ); Sat, 26 Sep 2009 04:17:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751465AbZIZIRI (ORCPT ); Sat, 26 Sep 2009 04:17:08 -0400 Received: from hera.kernel.org ([140.211.167.34]:42425 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbZIZIRH (ORCPT ); Sat, 26 Sep 2009 04:17:07 -0400 Subject: [PATCH] infiniband: fops_get is not required for core, uverbs_main.c From: Jaswinder Singh Rajput To: Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Date: Sat, 26 Sep 2009 13:46:01 +0530 Message-Id: <1253952962.3897.2.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-2.fc10) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 44 fops_get is useless as 'uverbs_event_fops' will always be 'true'. This also fix compilation warning : CC [M] drivers/infiniband/core/uverbs_main.o drivers/infiniband/core/uverbs_main.c: In function ‘ib_uverbs_alloc_event_file’: drivers/infiniband/core/uverbs_main.c:522: warning: the address of ‘uverbs_event_fops’ will always evaluate as ‘true’ Signed-off-by: Jaswinder Singh Rajput Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock --- drivers/infiniband/core/uverbs_main.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c index d3fff9e..a59ddd1 100644 --- a/drivers/infiniband/core/uverbs_main.c +++ b/drivers/infiniband/core/uverbs_main.c @@ -513,13 +513,8 @@ struct file *ib_uverbs_alloc_event_file(struct ib_uverbs_file *uverbs_file, goto err; } - /* - * fops_get() can't fail here, because we're coming from a - * system call on a uverbs file, which will already have a - * module reference. - */ filp = alloc_file(uverbs_event_mnt, dget(uverbs_event_mnt->mnt_root), - FMODE_READ, fops_get(&uverbs_event_fops)); + FMODE_READ, &uverbs_event_fops); if (!filp) { ret = -ENFILE; goto err_fd; -- 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/