Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbZIZJrk (ORCPT ); Sat, 26 Sep 2009 05:47:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751754AbZIZJrj (ORCPT ); Sat, 26 Sep 2009 05:47:39 -0400 Received: from poutre.nerim.net ([62.4.16.124]:58358 "EHLO poutre.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbZIZJri (ORCPT ); Sat, 26 Sep 2009 05:47:38 -0400 Date: Sat, 26 Sep 2009 11:47:40 +0200 From: Jean Delvare To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Mika Kuoppala , Peter Ujfalusi Subject: Re: [PATCH -next] i2c: uses/select RT_MUTEXES Message-ID: <20090926114740.182d8b70@hyperion.delvare> In-Reply-To: <4ABD4213.9010700@oracle.com> References: <20090925133830.1ba29584.sfr@canb.auug.org.au> <4ABD4213.9010700@oracle.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 39 Hi Randy, On Fri, 25 Sep 2009 15:20:03 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > i2c-core uses rt mutexes, so it needs to select that > kconfig symbol since there is no prompt for it. > > ERROR: "rt_mutex_lock" [drivers/i2c/i2c-core.ko] undefined! > ERROR: "__rt_mutex_init" [drivers/i2c/i2c-core.ko] undefined! > ERROR: "rt_mutex_trylock" [drivers/i2c/i2c-core.ko] undefined! > ERROR: "rt_mutex_unlock" [drivers/i2c/i2c-core.ko] undefined! > > Signed-off-by: Randy Dunlap > --- > drivers/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20090925.orig/drivers/i2c/Kconfig > +++ linux-next-20090925/drivers/i2c/Kconfig > @@ -5,6 +5,7 @@ > menuconfig I2C > tristate "I2C support" > depends on HAS_IOMEM > + select RT_MUTEXES > ---help--- > I2C (pronounce: I-square-C) is a slow serial bus protocol used in > many micro controller applications and developed by Philips. SMBus, Thanks for the fix, I've folded it into i2c-prevent-priority-inversion-on-top-of-bus-lock.patch. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/