Subject: Re: [PATCH v3 net-next-2.6] cxgb3: Added private MAC address and
 provisioning packet handler for iSCSI
From: Daniel Walker <dwalker@fifo99.com>
To: kxie@chelsio.com
Cc: davem@davemloft.net, swise@opengridcomputing.com, divy@chelsio.com,
       rakesh@chelsio.com, michaelc@cs.wisc.edu,
       James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org
In-Reply-To: <200909261903.n8QJ3D2b000882@localhost.localdomain>
References: <200909261903.n8QJ3D2b000882@localhost.localdomain>
Content-Type: text/plain
Date: Sat, 26 Sep 2009 12:22:39 -0700
Message-Id: <1253992959.20648.434.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 851
Lines: 28

On Sat, 2009-09-26 at 12:03 -0700, kxie@chelsio.com wrote:
>  enum {                 /* rx_offload flags */
>         T3_RX_CSUM      = 1 << 0,
>         T3_LRO          = 1 << 1,
>  };
>  
> +enum {
> +       LAN_MAC_IDX     = 0,
> +       SAN_MAC_IDX,
> +
> +       MAX_MAC_IDX
> +};

Why not name the enum and use it in the function declarations? I see
there are some other unnamed enums in there so you are following the
style in the file already.. However, naming the enum and using it allows
the input values to be known instead of just saying "int n", so I think
that's a better method..

Daniel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/