Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbZI0S3W (ORCPT ); Sun, 27 Sep 2009 14:29:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752412AbZI0S3V (ORCPT ); Sun, 27 Sep 2009 14:29:21 -0400 Received: from hiauly1.hia.nrc.ca ([132.246.100.193]:2024 "EHLO hiauly1.hia.nrc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbZI0S3V (ORCPT ); Sun, 27 Sep 2009 14:29:21 -0400 X-Greylist: delayed 451 seconds by postgrey-1.27 at vger.kernel.org; Sun, 27 Sep 2009 14:29:21 EDT Date: Sun, 27 Sep 2009 14:21:50 -0400 From: John David Anglin To: Julia Lawall Cc: Helge Deller , Kyle McMartin , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] arch/parisc: correct use of SHF_ALLOC Message-ID: <20090927182149.GA23464@hiauly1.hia.nrc.ca> Reply-To: John David Anglin References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: nrc.ca User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 45 Hi Kyle, I noticed today that this change is not in 2.6.31.1. Dave On Tue, 04 Aug 2009, Julia Lawall wrote: > From: Julia Lawall > > SHF_ALLOC is suitable for testing against the sh_flags field, not the > sh_type field. > > Signed-off-by: Julia Lawall > > --- > arch/parisc/kernel/module.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c > index ef5caf2..c904817 100644 > --- a/arch/parisc/kernel/module.c > +++ b/arch/parisc/kernel/module.c > @@ -853,7 +853,7 @@ int module_finalize(const Elf_Ehdr *hdr, > * ourselves */ > for (i = 1; i < hdr->e_shnum; i++) { > if(sechdrs[i].sh_type == SHT_SYMTAB > - && (sechdrs[i].sh_type & SHF_ALLOC)) { > + && (sechdrs[i].sh_flags & SHF_ALLOC)) { > int strindex = sechdrs[i].sh_link; > /* FIXME: AWFUL HACK > * The cast is to drop the const from > -- > To unsubscribe from this list: send the line "unsubscribe linux-parisc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/