Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852AbZI0TDm (ORCPT ); Sun, 27 Sep 2009 15:03:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752766AbZI0TDl (ORCPT ); Sun, 27 Sep 2009 15:03:41 -0400 Received: from fifo99.com ([67.223.236.141]:37293 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbZI0TDl (ORCPT ); Sun, 27 Sep 2009 15:03:41 -0400 Subject: Re: [PATCH] WARN_ONCE(): use bool for condition From: Daniel Walker To: Cesar Eduardo Barros Cc: linux-kernel@vger.kernel.org, Andrew Morton , Roland Dreier In-Reply-To: <4ABFB524.5030008@cesarb.net> References: <4ABFAB27.1040608@cesarb.net> <1254075912-17557-1-git-send-email-cesarb@cesarb.net> <1254076108.20648.529.camel@desktop> <4ABFB524.5030008@cesarb.net> Content-Type: text/plain Date: Sun, 27 Sep 2009 12:03:06 -0700 Message-Id: <1254078186.20648.531.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 23 On Sun, 2009-09-27 at 15:55 -0300, Cesar Eduardo Barros wrote: > Daniel Walker escreveu: > > On Sun, 2009-09-27 at 15:25 -0300, Cesar Eduardo Barros wrote: > >> - int __ret_warn_on = !!(condition); \ > >> + bool __ret_warn_on = (condition); \ > > > > Did you try it without removing the "!!" ? In my original email I tested > > the path of least resistance, and I left the "!!" in there.. > > Just tried, same result (it seems gcc can easily see past the double > negation). Ok, I'm not sure it's worth it then.. I'd prefer to move forward and assume newer compilers, but most kernel hackers use older compilers .. It's a pretty big size increase too.. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/