Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbZI1ELJ (ORCPT ); Mon, 28 Sep 2009 00:11:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750858AbZI1ELI (ORCPT ); Mon, 28 Sep 2009 00:11:08 -0400 Received: from one.firstfloor.org ([213.235.205.2]:46092 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbZI1ELI (ORCPT ); Mon, 28 Sep 2009 00:11:08 -0400 Date: Mon, 28 Sep 2009 06:11:08 +0200 From: Andi Kleen To: Nick Piggin Cc: Andi Kleen , Hugh Dickins , Wu Fengguang , Andrew Morton , linux-mm@kvack.org, LKML Subject: Re: [RFC][PATCH] HWPOISON: remove the unsafe __set_page_locked() Message-ID: <20090928041108.GD1656@one.firstfloor.org> References: <20090926031537.GA10176@localhost> <20090926190645.GB14368@wotan.suse.de> <20090926213204.GX30185@one.firstfloor.org> <20090927192251.GB6327@wotan.suse.de> <20090927230118.GH6327@wotan.suse.de> <20090928011943.GB1656@one.firstfloor.org> <20090928025741.GI6327@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090928025741.GI6327@wotan.suse.de> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 31 On Mon, Sep 28, 2009 at 04:57:41AM +0200, Nick Piggin wrote: > On Mon, Sep 28, 2009 at 03:19:43AM +0200, Andi Kleen wrote: > > > There is no real rush AFAIKS to fix this one single pagecache site > > > while we have problems with slab allocators and all other unaudited > > > places that nonatomically modify page flags with an elevated > > > > hwpoison ignores slab pages. > > "ignores" them *after* it has already written to page flags? > By that time it's too late. Yes, currently the page lock comes first. The only exception is for page count == 0 pages. I suppose we could move the slab check up, but then it only helps when slab is set. So if you make slab use refcount == 0 pages that would help. > Well it's fundamentally badly buggy, rare or not. We could avoid Let's put it like this -- any access to the poisoned cache lines in that page will trigger a panic anyways. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/