Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbZI1Ihv (ORCPT ); Mon, 28 Sep 2009 04:37:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751661AbZI1Ihv (ORCPT ); Mon, 28 Sep 2009 04:37:51 -0400 Received: from mail-fx0-f218.google.com ([209.85.220.218]:45126 "EHLO mail-fx0-f218.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbZI1Ihu convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2009 04:37:50 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=wjpY+Yu4MdW6AAVpkND8NNxERIb90WhQMd0uhUktNaUm+7Ubi7Ee8bJr3m5V6dz8bx 41MrW0dhoJR5l79bmIWgO55La4OOQczbqgGdU8aIiZyg2HZM1E0FYYdlRU0Vw/AjsW32 E/sGp5YpHKJotb1ipvKvYMSEZ7z5xms6dR3+Q= MIME-Version: 1.0 In-Reply-To: <20090928075540.GD6668@linux-sh.org> References: <20090928075540.GD6668@linux-sh.org> Date: Mon, 28 Sep 2009 11:37:52 +0300 X-Google-Sender-Auth: e35c6b2832379842 Message-ID: <84144f020909280137n6126eb7bm39a32dd7258694d@mail.gmail.com> Subject: Re: [PATCH] kmemtrace: Fix up tracer registration. From: Pekka Enberg To: Paul Mundt , Li Zefan , Ingo Molnar , Pekka Enberg , Eduard - Gabriel Munteanu , Steven Rostedt , Frederic Weisbecker , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 21 On Mon, Sep 28, 2009 at 10:55 AM, Paul Mundt wrote: > Commit ddc1637af217dbd8bc51f30e6d24e84476a869a6 > ("kmemtrace: Print binary output only if 'bin' option is set") ended up > inverting the error detection logic. register_tracer() returns 0 on > success, which this change caused to treat as an error, resulting in: > > [ ? ?0.132000] Warning: could not register the kmem tracer > > as well as bailing out of the initcall with an error value. This > restores the old logic. > > Signed-off-by: Paul Mundt Looks good to me. Thanks Paul! Acked-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/