Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbZI1Qpd (ORCPT ); Mon, 28 Sep 2009 12:45:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752744AbZI1Qpc (ORCPT ); Mon, 28 Sep 2009 12:45:32 -0400 Received: from smtp2.ultrahosting.com ([74.213.174.253]:35378 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752677AbZI1Qpb (ORCPT ); Mon, 28 Sep 2009 12:45:31 -0400 Date: Mon, 28 Sep 2009 12:40:56 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Tejun Heo cc: Tony Vroon , Linux Kernel , Rusty Russell , Ingo Molnar , "H. Peter Anvin" Subject: Re: [PATCH] percpu: fix unit_map[] verification in pcpu_setup_first_chunk() In-Reply-To: <4AC0E6A3.4040500@kernel.org> Message-ID: References: <4ABAC2F1.3020302@kernel.org> <1254055797.2756.1.camel@localhost> <4AC0E201.2020006@kernel.org> <4AC0E5D8.6090707@kernel.org> <4AC0E6A3.4040500@kernel.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 18 On Tue, 29 Sep 2009, Tejun Heo wrote: > > Christoph, can you please elaborate why nr_cpu_ids < NR_CPUS is > broken? If its just an internal number that becomes larger than NR_CPUS then everything is fine. But if a real cpu id (returned by smp_processor_id()) gets larger than NR_CPUS then we get into trouble with the parts of the kernel that index by cpu id. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/