Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbZI3Ip0 (ORCPT ); Wed, 30 Sep 2009 04:45:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752819AbZI3IpZ (ORCPT ); Wed, 30 Sep 2009 04:45:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17299 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbZI3IpZ (ORCPT ); Wed, 30 Sep 2009 04:45:25 -0400 Message-ID: <4AC31AA5.4060609@redhat.com> Date: Wed, 30 Sep 2009 10:45:25 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 MIME-Version: 1.0 To: Zachary Amsden CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Marcelo Tosatti Subject: Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function. References: <4AC1C59F.6010703@redhat.com> <1254260317-3490-1-git-send-email-zamsden@redhat.com> In-Reply-To: <1254260317-3490-1-git-send-email-zamsden@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 19 On 09/29/2009 11:38 PM, Zachary Amsden wrote: > Signed-off-by: Zachary Amsden > Looks good. Is anything preventing us from unifying the constant_tsc and !same paths? We could just do a quick check in the notifier, see the tsc frequency hasn't changed, and return. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/