Date: Wed, 30 Sep 2009 11:20:23 +0200
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] move #define pr_fmt KBUILD_MODNAME and KMSG_COMPONENT to
 Makefiles?
Message-ID: <20090930112023.4fbb3da0@mschwide.boeblingen.de.ibm.com>
In-Reply-To: <1254297299.2960.55.camel@Joe-Laptop.home>
References: <1254248104.28232.447.camel@Joe-Laptop.home>
	<20090930065533.GB13850@merkur.ravnborg.org>
	<1254297299.2960.55.camel@Joe-Laptop.home>
Organization: IBM Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1211
Lines: 34

On Wed, 30 Sep 2009 00:54:59 -0700
Joe Perches <joe@perches.com> wrote:

> If something like were added to a module Makefile:
> 
> 	ccflags-y += -D "pr_fmt(fmt)=KBUILD_MODNAME \": \" fmt"

That would define a pr_fmt macro for ALL source files. That would add
the prefix to every single pr_xxx printk. That a) changes the text of
these printk and b) makes printks that already have a different prefix
look very funny. The point is that you need to adapt you source file in
order to use the pr_fmt prefix mechanis, no automatic conversion is
possible.

> or if necessary a per-file entry in the Makefile:
> 
> 	CFLAGS_foo.o += -D "pr_fmt(fmt)=KBUILD_MODNAME \": \" fmt"

Where is the difference between the definition of the macro in the
source file? It's still one additional line, no? And if you are
dreaming of converting all source files to the pr_fmt mechanism, this
is a big effort ..

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/