Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329AbZI3MQl (ORCPT ); Wed, 30 Sep 2009 08:16:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752588AbZI3MQl (ORCPT ); Wed, 30 Sep 2009 08:16:41 -0400 Received: from mtagate4.de.ibm.com ([195.212.17.164]:44945 "EHLO mtagate4.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbZI3MQk (ORCPT ); Wed, 30 Sep 2009 08:16:40 -0400 Date: Wed, 30 Sep 2009 14:16:41 +0200 From: Martin Schwidefsky To: Kamalesh Babulal Cc: linux-next@vger.kernel.org, LKML , sfr@canb.auug.org.au, heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org Subject: Re: linux-next: Tree for September 30 Message-ID: <20090930141641.3652fc99@mschwide.boeblingen.de.ibm.com> In-Reply-To: <20090930095254.GB5416@linux.vnet.ibm.com> References: <20090930133745.36a6beea.sfr@canb.auug.org.au> <20090930095254.GB5416@linux.vnet.ibm.com> Organization: IBM Corporation X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 58 On Wed, 30 Sep 2009 15:22:54 +0530 Kamalesh Babulal wrote: > next-20090930 randconfig build breaks, character driver > > ERROR: "ccw_device_force_console" [drivers/s390/char/raw3270.ko] undefined! > make[1]: *** [__modpost] Error 1 This patch should fix the build breakage: -- Subject: [PATCH] 3270 console build fix From: Sebastian Ott Fix this build failure: drivers/s390/built-in.o: In function `raw3270_pm_unfreeze': (.text+0x3ac04): undefined reference to `ccw_device_force_console' with: CONFIG_TN3270=y CONFIG_TN3270_CONSOLE=n CONFIG_TN3215_CONSOLE=n Reported-by: Kamalesh Babulal Signed-off-by: Sebastian Ott Signed-off-by: Martin Schwidefsky --- drivers/s390/char/raw3270.c | 2 ++ 1 file changed, 2 insertions(+) diff -urpN linux-2.6/drivers/s390/char/raw3270.c linux-2.6-patched/drivers/s390/char/raw3270.c --- linux-2.6/drivers/s390/char/raw3270.c 2009-09-10 00:13:59.000000000 +0200 +++ linux-2.6-patched/drivers/s390/char/raw3270.c 2009-09-30 14:14:44.000000000 +0200 @@ -1361,11 +1361,13 @@ static int raw3270_pm_start(struct ccw_d void raw3270_pm_unfreeze(struct raw3270_view *view) { +#ifdef CONFIG_TN3270_CONSOLE struct raw3270 *rp; rp = view->dev; if (rp && test_bit(RAW3270_FLAGS_FROZEN, &rp->flags)) ccw_device_force_console(); +#endif } static struct ccw_device_id raw3270_id[] = { -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/