Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153AbZI3NWO (ORCPT ); Wed, 30 Sep 2009 09:22:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753424AbZI3NWO (ORCPT ); Wed, 30 Sep 2009 09:22:14 -0400 Received: from fias.uni-frankfurt.de ([141.2.248.1]:48430 "EHLO fias.uni-frankfurt.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753076AbZI3NWN (ORCPT ); Wed, 30 Sep 2009 09:22:13 -0400 From: Jan Scholz To: Jan Scholz Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , "Adrian Ulrich" , "Jiri Kosina" Subject: Re: [Bug #13935] 2.6.31-rcX breaks Apple MightyMouse (Bluetooth version) References: <87hbwewlk4.fsf@scholz.fias.uni-frankfurt.de> Date: Wed, 30 Sep 2009 15:21:03 +0200 In-Reply-To: <87hbwewlk4.fsf@scholz.fias.uni-frankfurt.de> (Jan Scholz's message of "Tue, 11 Aug 2009 15:02:19 +0200") Message-ID: <878wfwwou8.fsf@scholz.fias.uni-frankfurt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2667 Lines: 66 Hi, now that the patch "HID: completely remove apple mightymouse from blacklist" is merged upstream as "42960a13001aa6df52ca9952ce996f94a744ea65" I think it should be merged in the v2.6.31-stable series as well. Best regards, Jan Jan Scholz writes: > I can confirm the reported bug, but for me reverting fa047e4f6fa63a6 is > not sufficient. I have to remove the device id of the mighty mouse from > the hid_blacklist list in drivers/hid/hid-core.c as well, see the patch below. > > "Rafael J. Wysocki" writes: > >> This message has been generated automatically as a part of a report >> of recent regressions. >> >> The following bug entry is on the current list of known regressions >> from 2.6.30. Please verify if it still should be listed and let me know >> (either way). >> >> >> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13935 >> Subject : 2.6.31-rcX breaks Apple MightyMouse (Bluetooth version) >> Submitter : Adrian Ulrich >> Date : 2009-08-08 22:08 (2 days old) >> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fa047e4f6fa63a6e9d0ae4d7749538830d14a343 >> > > From b7393ed6dfe00c9e126a2dd34659156548df15cc Mon Sep 17 00:00:00 2001 > From: Jan Scholz > Date: Tue, 11 Aug 2009 14:33:27 +0200 > Subject: [PATCH] HID: commit fa047e4f is incomplete > > Commit fa047e4f6fa63a6e9d0ae4d7749538830d14a343 "HID: fix inverted > wheel for bluetooth version of apple mighty mouse" is incomplete. If > we remove Apple MightyMouse (bluetooth version) from the list of > apple_devices in drivers/hid/hid-apple.c we have to remove it from > hid_blacklist in drivers/hid/hid-core.c as well. > > Signed-off-by: Jan Scholz > --- > drivers/hid/hid-core.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 5eb10c2..047844d 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1319,7 +1319,6 @@ static const struct hid_device_id hid_blacklist[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, > { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) }, > > - { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, 0x030c) }, > { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) }, > { } > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/