Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755298AbZJAAjW (ORCPT ); Wed, 30 Sep 2009 20:39:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755225AbZJAAjV (ORCPT ); Wed, 30 Sep 2009 20:39:21 -0400 Received: from mail.vyatta.com ([76.74.103.46]:40812 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139AbZJAAjU (ORCPT ); Wed, 30 Sep 2009 20:39:20 -0400 Date: Wed, 30 Sep 2009 17:39:23 -0700 From: Stephen Hemminger To: Shreyas Bhatewara Cc: linux-kernel , netdev , Stephen Hemminger , "David S. Miller" , Jeff Garzik , Anthony Liguori , Chris Wright , Greg Kroah-Hartman , Andrew Morton , virtualization , pv-drivers Subject: Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3 Message-ID: <20090930173923.4520716a@s6510> In-Reply-To: References: Organization: Vyatta X-Mailer: Claws Mail 3.6.1 (GTK+ 2.16.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 36 On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) Shreyas Bhatewara wrote: Note: your patch was linewrapped again > + > + > +static void > +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64) > +{ > + struct net_device *netdev = adapter->netdev; > + > + netdev->features = NETIF_F_SG | > + NETIF_F_HW_CSUM | > + NETIF_F_HW_VLAN_TX | > + NETIF_F_HW_VLAN_RX | > + NETIF_F_HW_VLAN_FILTER | > + NETIF_F_TSO | > + NETIF_F_TSO6; > + > + printk(KERN_INFO "features: sg csum vlan jf tso tsoIPv6"); > + > + adapter->rxcsum = true; > + adapter->jumbo_frame = true; > + > + if (!disable_lro) { > + adapter->lro = true; > + printk(" lro"); > + } Why not use NETIF_F_LRO and ethtool to control LRO support? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/