Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755985AbZJAI0W (ORCPT ); Thu, 1 Oct 2009 04:26:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932097AbZJAI0S (ORCPT ); Thu, 1 Oct 2009 04:26:18 -0400 Received: from Cpsmtpm-eml107.kpnxchange.com ([195.121.3.11]:56601 "EHLO CPSMTPM-EML107.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755980AbZJAI0P (ORCPT ); Thu, 1 Oct 2009 04:26:15 -0400 From: Frans Pop To: manty@manty.net Subject: Re: kernel BUG at drivers/ide/ide-disk.c:187 (2.6.31) Date: Thu, 1 Oct 2009 10:26:14 +0200 User-Agent: KMail/1.9.9 Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz References: <20090930110529.GA3676@dis.manty.net> <20090930110529.GA3676@dis.manty.net> <20090930235709.43ff1255.akpm@linux-foundation.org> In-reply-To: <20090930235709.43ff1255.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910011026.17510.elendil@planet.nl> X-OriginalArrivalTime: 01 Oct 2009 08:26:18.0398 (UTC) FILETIME=[D95CABE0:01CA4270] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 35 Hi Manty, Andrew Morton wrote: > On Wed, 30 Sep 2009 13:05:29 +0200 Santiago Garcia Mantinan wrote: >> kernel BUG at drivers/ide/ide-disk.c:187! Looks like this is a deliberate test for unknown requests that was added in 2.6.31 with the following commit: commit 2c7eaa43c3bb7b3b9fe2051d17f308c1f0728c78 Author: Bartlomiej Zolnierkiewicz Date: Mon Jun 15 22:16:10 2009 +0200 ide: BUG() on unknown requests Unsupported requests should be never handed down to device drivers and the best thing we can do upon discovering such request inside driver's ->do_request method is to just BUG(). In previous kernels the code would not dump, but still fail and print the request flags, identified by "ide_do_rw_disk - bad command", to the kernel log. Manty: Have you ever seen such messages with previous kernels? Question for IDE maintainers: should maybe the old printing of request info be reinstated, or can the request flags also be obtained from the BUG info? Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/