Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932431AbZJAIhE (ORCPT ); Thu, 1 Oct 2009 04:37:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932414AbZJAIg6 (ORCPT ); Thu, 1 Oct 2009 04:36:58 -0400 Received: from cantor.suse.de ([195.135.220.2]:38684 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207AbZJAIg4 (ORCPT ); Thu, 1 Oct 2009 04:36:56 -0400 Date: Thu, 01 Oct 2009 10:36:59 +0200 Message-ID: From: Takashi Iwai To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove In-Reply-To: <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 45 At Thu, 1 Oct 2009 10:28:10 +0200, Uwe Kleine-König wrote: > > The function hal2_remove is defined using __exit, so don't use __devexit_p > but __exit_p to wrap it. I think it's the other way round. We should replace __exit with __devexit. Ditto for sound/mips/sgio2audio.c. thanks, Takashi > > Signed-off-by: Uwe Kleine-König > Cc: Takashi Iwai > Cc: Jaroslav Kysela > Cc: alsa-devel@alsa-project.org > Cc: linux-kernel@vger.kernel.org > --- > sound/mips/hal2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c > index c52691c..72523a7 100644 > --- a/sound/mips/hal2.c > +++ b/sound/mips/hal2.c > @@ -926,7 +926,7 @@ static int __exit hal2_remove(struct platform_device *pdev) > > static struct platform_driver hal2_driver = { > .probe = hal2_probe, > - .remove = __devexit_p(hal2_remove), > + .remove = __exit_p(hal2_remove), > .driver = { > .name = "sgihal2", > .owner = THIS_MODULE, > -- > 1.6.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/